Skip to content

fix: issue 1779: more correct way to add proxy_plugins values #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: issue 1779: more correct way to add proxy_plugins values #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f074034
issue 1779: more correct way to add proxy_plugins values
botinca Oct 16, 2025
e6c276b
issue 1779: nydus-snapshotter helm chart version bump 0.0.10 > 0.0.11
botinca Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/dragonfly-stack/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@ dependencies:
repository: https://dragonflyoss.github.io/helm-charts/
condition: dragonfly.enable
- name: nydus-snapshotter
version: 0.0.10
version: 0.0.11
repository: https://dragonflyoss.github.io/helm-charts/
condition: nydus-snapshotter.enable
2 changes: 1 addition & 1 deletion charts/dragonfly-stack/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,4 +560,4 @@ helm delete dragonfly --namespace dragonfly-system
| Repository | Name | Version |
|------------|------|---------|
| https://dragonflyoss.github.io/helm-charts/ | dragonfly | 1.1.67 |
| https://dragonflyoss.github.io/helm-charts/ | nydus-snapshotter | 0.0.10 |
| https://dragonflyoss.github.io/helm-charts/ | nydus-snapshotter | 0.0.11 |
2 changes: 1 addition & 1 deletion charts/nydus-snapshotter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: nydus-snapshotter
description: Nydus snapshotter is an external plugin of containerd for Nydus image service which implements a chunk-based content-addressable filesystem on top of a called RAFS.
icon: https://github.com/dragonflyoss/image-service/raw/master/misc/logo.svg
type: application
version: 0.0.10
version: 0.0.11
appVersion: 0.9.0
keywords:
- nydus
Expand Down
10 changes: 3 additions & 7 deletions charts/nydus-snapshotter/templates/nydus-snapshotter/snapshotter-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,13 +123,9 @@ spec:
toml set --overwrite $etcContainerd plugins.\"io.containerd.grpc.v1.cri\".containerd.disable_snapshot_annotations false
toml set --overwrite $etcContainerd plugins.\"io.containerd.grpc.v1.cri\".containerd.snapshotter nydus

# toml command not support to set block, so just use cat command.
cat << EOF >> $etcContainerd
[proxy_plugins]
[proxy_plugins.nydus]
type = "snapshot"
address = "/run/containerd-nydus/containerd-nydus-grpc.sock"
EOF
#toml will create "proxy_plugins" table if it doesn't exist
Copy link
Contributor

@imeoer imeoer Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a space after #. :)

toml set --overwrite $etcContainerd 'proxy_plugins.nydus.address' '/run/containerd-nydus/containerd-nydus-grpc.sock'
toml set --overwrite $etcContainerd 'proxy_plugins.nydus.type' 'snapshot'

volumeMounts:
- name: containerd-conf
Expand Down
Loading