[Wisp] Remove CoroutineSupport Lock in Java and unnecessary function coroutineMove. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coroutineMove. Summary: In Java17, we protect double linked list of coroutine in C++. So there is no need to use Locker in Java to protect it. And also, function moveCoroutine is unnecessary, so we should remove it. Refine nmethods_do mark active. Test Plan: all wisp tests Reviewed-by: yulei Issue: dragonwell-project#189
yuleil
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Wisp] Remove CoroutineSupport Lock in Java and unnecessary function coroutineMove.
Summary:
In Java17, we protect double linked list of coroutine in C++. So there is no need to use Locker in Java to protect it. And also, function moveCoroutine is unnecessary, so we should remove it. Refine nmethods_do mark active.
Test Plan: all wisp tests
Reviewed-by: yulei
Issue:
#189