[Wisp] Port Wisp1/2 to JDK17. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Port Wisp1/2 to JDK11 includes the changes in 8.6.11_fp1 - initializing process improvement - WispCounterMXBean and WispPerfCounterMonitor aren't supported Test Plan: test/hotspot/jtreg/runtime/coroutine/ test/jdk/com/alibaba/wisp test/jdk/com/alibaba/wisp2 Reviewed-by: yulei Issue: dragonwell-project#77
ZhaiMo15
force-pushed
the
wisp-port2
branch
3 times, most recently
from
99600c7
to
cb229dd
Compare
yuleil
previously approved these changes
Jul 3, 2023
yuleil
dismissed
their stale review
"Fix bugs in previous commit. " needs further review
yuleil
reviewed
Jul 3, 2023
Summary: - Basic change such as naming convention or typo. - Fix wrong usage of some functions. - Add one more dereference when encouter _threadObj since it's oop* rather than oop in Java11. - Add WispThread convertion in clinit_barrier when UseWispMonitor is enabled, because ini thread is WispThread. - Pass correct current thread to ExceptionMark constructor in Runtime1::monitorexit_wisp. - Modify code in test to pass hotspot and jdk jtregs. - Fix wisp2 create property crash. - Delete control node in make_runtime_call() since it is wrong that treating control node to memory node. - Refine coroutine properties append logic(From JVM_GetProperties to Arguments::init_system_properties). - Hoist code of safepoint state out of MutexLocker to prevent safepoint deadlock problem. - Fix WispThread BarrierSet and JavaCalls assert. - Fix Thread interrupted flag in public class Thread. - Fix threadObj changed in coroutine steal. - Add more debug functions for switchTo. - Delete jniDetachThreadHoldingMonitorTest.sh, jniMonitorExitTest.sh and SelectorInitCriticalTest.java because SelectorProvider removed lock in Java17. - test/hotspot/jtreg/runtime/jni/registerNativesWarning/TestRegisterNativesWarning.java: yield() in Thread.java is not a native method after we port wisp coroutine to JDK. Thus we use currentTimeMillis() instead. - vmTestbase/nsk/monitoring/stress/thread/strace001/TestDescription.java: Add "java.lang.Thread.sleep0" and "java.lang.Thread.yield0" in expectedTrace, and let expectedLength = depth + 4. - test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/ThreadController.java: Add sleep0 and yield0 in expectedMethods. - test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace00*.java: Add sleep0 and yield0 in EXPECTED_METHODS. - test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/thread/SleepingThread.java and RunningThread.java: Add sleep0 and yield0 in expectedMethods. - test/hotspot/jtreg/vmTestbase/nsk/share/locks/LockingThread.java: Add 1 to expectedDepth and add function myWait to add 1 more stack frame. - test/jdk/java/beans/XMLDecoder/8028054/Task.java: Remove "java.dyn.CoroutineSupport" from fileNames. - test/jdk/jdk/jfr/event/runtime/TestSystemPropertyEvent.java: Add "com.alibaba.coroutine.enableCoroutine" to SystemProperty. - test/jdk/com/alibaba/wisp2/Wisp2ShutdownTest.java: Change awaitTermination time to 5 seconds, because all coroutines may not terminated in 1 second. - Put trace_switch, print_site and coroutine_switch_trace into debug version. Reviewed-by: yulei Test Plan: test/hotspot/jtreg/runtime/coroutine/ test/jdk/com/alibaba/wisp test/jdk/com/alibaba/wisp2 Issue: dragonwell-project#77
yuleil
approved these changes
Jul 6, 2023
WindChang1999
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan:
test/hotspot/jtreg/runtime/coroutine/
test/jdk/com/alibaba/wisp
test/jdk/com/alibaba/wisp2
Reviewed-by: yulei
Issue:
#77