build: Add support for linking to shared falcosecurity libraries. #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apteryks
commented
May 8, 2024
Apteryks
commented
- cmake/modules/falcosecurity-libs.cmake (USE_BUNDLED_FALCOSECURITY_LIBS): New option. Look for libsinsp via pkg-config unless it's enabled.
- userspace/sysdig/CMakeLists.txt: Adjust link directives accordingly. Remove extraneous zlib include.
therealbobo
requested changes
May 8, 2024
|
Note that this depends on falcosecurity/libs#1842 to work. |
* cmake/modules/falcosecurity-libs.cmake (USE_BUNDLED_FALCOSECURITY_LIBS): New option. Look for libsinsp via pkg-config unless it's enabled. * userspace/sysdig/CMakeLists.txt: Adjust link directives accordingly. Remove extraneous zlib include. Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Apteryks
force-pushed
the
support-shared-falcosecurity-libs
branch
from
9327969
to
35ea4d3
Compare
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Not stale (that's an aggressive bot!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.