Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fsconfing while creating virtual folders #1891

Closed
wants to merge 4 commits into from

Conversation

firatkucuk
Copy link

@firatkucuk firatkucuk commented Feb 10, 2025

Checklist for Pull Requests


Closes #1890

@firatkucuk firatkucuk requested a review from drakkan as a code owner February 10, 2025 13:35
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2025

CLA assistant check
All committers have signed the CLA.

@firatkucuk
Copy link
Author

@drakkan Could you please take a look at this one? I am getting an error regarding pipeline credits.

@drakkan
Copy link
Owner

drakkan commented Mar 2, 2025

@drakkan Could you please take a look at this one? I am getting an error regarding pipeline credits.

Thanks for your contribution. The CI is now fixed.

Sorry, I'm busy with many other things, I don't have time to go into this at the moment. A test case or at least a simple, self contained, reproducer (for example a small bash script) would be helpful.

This could be a bug in the handling of the pre-login hook, but in general virtual folders are referenced by name, so fsconfig should remain unchanged.

A PR like this, without a test case, looks more like a support request 😄

@firatkucuk
Copy link
Author

firatkucuk commented Mar 11, 2025

@drakkan I have created this app. I hope it helps you to understand the issue.

I noticed in the example; local virtual folder mapping does not working as well. This PR proposes a fix for the virtual folders which is bound to an FsConfig but local mapping doesn't have one. I added FsConfig field but we need to add mapped_path. After you check the code. Maybe we can discuss further.

@drakkan drakkan closed this in cf573fc Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: prelogin hook doesn't work with virtualfolders
3 participants