support for RFC9380 DST G1 scheme #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CluEleSsUK
commented
Jun 20, 2023
CluEleSsUK
commented
- refactored the IBE code to be more generalised
|
Created a draft of this - just realised I haven't updated the client yet, so should probably do that first, then update tlock go, then create test vectors |
AnomalRoil
reviewed
Sep 18, 2023
|
yes and no - the interface for encryption and decryption hasn't changed, though users who have been using |
|
actually wait it's still in |
- refactored the IBE code to be more generalised
* fixed some compat tests * pointed the URLs to the right places (left the fastnet ones for compat)
CluEleSsUK
force-pushed
the
feature/support-for-rfc-g1-swap
branch
from
1cbc84d
to
6a29950
Compare
AnomalRoil
reviewed
Sep 21, 2023
AnomalRoil
reviewed
Sep 21, 2023
| const opts = { | ||
| ...defaultChainOptions, | ||
| chainVerificationParams: { | ||
| chainHash: "52db9ba70e0cc0f6eaf7803dd07447a1f5477735fd3f661792ba94600c84e971", |
There was a problem hiding this comment.
Could have added a comment with the name of the network :P
| return new HttpChainClient(chain, opts) | ||
| } | ||
|
|
||
| export function nonRFCMainnetClient(): HttpChainClient { | ||
| const opts = { | ||
| ...defaultChainOptions, | ||
| chainVerificationParams: { | ||
| chainHash: "dbd506d6ef76e5f386f41c651dcb808c5bcbd75471cc4eafa3f4df7ad4e4c493", |
There was a problem hiding this comment.
Could have added a comment with the name of the network :P
CluEleSsUK
force-pushed
the
feature/support-for-rfc-g1-swap
branch
from
b6d496f
to
484df96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.