Skip to content

fix: refactor elementPointerDown to use useRef #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −7
Open

fix: refactor elementPointerDown to use useRef #745

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
906f484
fix: refactor elementPointerDown to use useRef
maynkxx Nov 27, 2025
b60dcc7
Merge branch 'main' into fix/element-pointer-down
maynkxx Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/components/EditorCanvas/Canvas.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ export default function Canvas() {
});
// this is used to store the element that is clicked on
// at the moment, and shouldn't be a part of the state
let elementPointerDown = null;
// this is used to store the element that is clicked on
// at the moment, and shouldn't be a part of the state
const elementPointerDown = useRef(null);

const isSameElement = (el1, el2) => {
return el1.id === el2.id && el1.type === el2.type;
Expand Down Expand Up @@ -429,12 +431,12 @@ export default function Canvas() {
y1: pointer.spaces.diagram.y,
x2: pointer.spaces.diagram.x,
y2: pointer.spaces.diagram.y,
show: elementPointerDown === null || !elementPointerDown.element.locked,
show: elementPointerDown.current === null || !elementPointerDown.current.element.locked,
ctrlKey: e.ctrlKey,
metaKey: e.metaKey,
});
if (elementPointerDown !== null) {
handlePointerDownOnElement(e, elementPointerDown);
if (elementPointerDown.current !== null) {
handlePointerDownOnElement(e, elementPointerDown.current);
}
pointer.setStyle("crosshair");
} else if (isMouseMiddleButton) {
Expand Down Expand Up @@ -733,7 +735,7 @@ export default function Canvas() {
setResize={setAreaResize}
setInitDimensions={setAreaInitDimensions}
onPointerDown={() => {
elementPointerDown = {
elementPointerDown.current = {
element: a,
type: ObjectType.AREA,
};
Expand All @@ -751,7 +753,7 @@ export default function Canvas() {
handleGripField={handleGripField}
setLinkingLine={setLinkingLine}
onPointerDown={() => {
elementPointerDown = {
elementPointerDown.current = {
element: table,
type: ObjectType.TABLE,
};
Expand All @@ -771,7 +773,7 @@ export default function Canvas() {
key={n.id}
data={n}
onPointerDown={() => {
elementPointerDown = {
elementPointerDown.current = {
element: n,
type: ObjectType.NOTE,
};
Expand Down