[WIP] Add tutorials describing basic features of the product#107
[WIP] Add tutorials describing basic features of the product#107
Conversation
vtymtsiv
force-pushed
the
feature/DF-shepherd
branch
from
f0c3cb4 to
602afa2
Compare
vtymtsiv
force-pushed
the
feature/DF-shepherd
branch
from
2961357 to
bd05a0a
Compare
vtymtsiv
force-pushed
the
feature/DF-shepherd
branch
from
04d42a1 to
4720f73
Compare
OlegLazaryev
left a comment
OlegLazaryev
left a comment
There was a problem hiding this comment.
Reviewed.
Let's discuss.
app/admin_components/adf-tutorial/service-tutorial.directive.js
Outdated
Show resolved
Hide resolved
app/admin_components/adf-tutorial/service-tutorial.directive.js
Outdated
Show resolved
Hide resolved
app/admin_components/adf-tutorial/service-tutorial.directive.js
Outdated
Show resolved
Hide resolved
app/admin_components/adf-tutorial/service-tutorial.directive.js
Outdated
Show resolved
Hide resolved
app/admin_components/adf-tutorial/service-tutorial.directive.js
Outdated
Show resolved
Hide resolved
app/admin_components/adf-tutorial/service-tutorial.directive.js
Outdated
Show resolved
Hide resolved
|
|
||
| }); | ||
|
|
||
| subscribeHighlightingElement(step1); |
There was a problem hiding this comment.
This line is duplicated several times. What in this case makes it hardly maintainable. I have some ideas how to generalize it. Let's discuss in-person.
app/admin_components/adf-tutorial/service-tutorial.directive.js
Outdated
Show resolved
Hide resolved
| } | ||
| }); | ||
|
|
||
| var step1 = tour.addStep('services-tab', { |
There was a problem hiding this comment.
I have an idea of how to generalize the creation of steps. I think we can introduce a kind of a factory method to do that. Let's discuss in-person.
OlegLazaryev
left a comment
OlegLazaryev
left a comment
There was a problem hiding this comment.
@volodymyrtymtsiv reviewed.
Let's discuss.
app/services/tutorial.service.js
Outdated
| var selector = getSelector(step); | ||
|
|
||
| step.on('show', function () { | ||
| angular.element(selector).addClass('highlighted-element'); |
There was a problem hiding this comment.
Let's use jQuery selector instead of Angular.
app/services/tutorial.service.js
Outdated
| angular.element(selector).addClass('highlighted-element'); | ||
| }); | ||
| step.on('before-hide', function () { | ||
| angular.element(selector).removeClass('highlighted-element') |
There was a problem hiding this comment.
Let's use jQuery selector instead of Angular.
app/admin_components/adf-tutorial/service-tutorial.directive.js
Outdated
Show resolved
Hide resolved
|
A general notice which is looking like a bug:
|
OlegLazaryev
left a comment
OlegLazaryev
left a comment
There was a problem hiding this comment.
@volodymyrtymtsiv
Left you some more comments.
I think it is going to be the last round of review.
We will improve the remaining technical debt in the next related PRs.
Let me now when finished.
vtymtsiv
force-pushed
the
feature/DF-shepherd
branch
from
45f9c4e to
0addeef
Compare
vtymtsiv
force-pushed
the
feature/DF-shepherd
branch
from
efb4071 to
84ef713
Compare
Refactor
…-scripting Feature/df tutorial scripting
|
@wjgilmore please review. |
|
Thank you will review this week. |
wjgilmore
left a comment
wjgilmore
left a comment
There was a problem hiding this comment.
@volodymyrpoli do not merge this change. We now do this in Intercom.
4 participants
Uh oh!
There was an error while loading. Please reload this page.