Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vite.config.js #544

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Update vite.config.js #544

merged 1 commit into from
Jan 4, 2025

Conversation

dreamhunter2333
Copy link
Owner

@dreamhunter2333 dreamhunter2333 commented Jan 4, 2025

PR Type

enhancement


Description

  • Add support for top-level await in Vite configuration.

  • Update vite.config.js to include esbuild configuration.


Changes walkthrough 📝

Relevant files
Enhancement
vite.config.js
Add esbuild configuration for top-level await support       

frontend/vite.config.js

  • Added esbuild configuration to support top-level await.
  • Updated define section in Vite configuration.
  • +5/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @dreamhunter2333 dreamhunter2333 merged commit e9748be into main Jan 4, 2025
    1 check passed
    @dreamhunter2333 dreamhunter2333 deleted the fix-build branch January 4, 2025 18:05
    Copy link

    github-actions bot commented Jan 4, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Validation

    Ensure that the esbuild configuration for top-level-await is correctly implemented and does not conflict with other settings in the Vite configuration.

    esbuild: {
      supported: {
        'top-level-await': true
      },

    Copy link

    github-actions bot commented Jan 4, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant