Conversation
Committer: Ty Gavin <ty.gavin@dremio.com>
adding an example for C#
csharp/example/Program.cs
Outdated
| using Apache.Arrow.Flight; | ||
| using Apache.Arrow; | ||
|
|
||
| namespace FlightClientExample |
There was a problem hiding this comment.
Out of curiosity, is there a reason why a namespace is needed here?
csharp/example/Program.cs
Outdated
| { | ||
| public static async Task Main(string[] args) | ||
| { | ||
| string host = "localhost"; |
There was a problem hiding this comment.
Could these magic numbers be placed outside of the Main function like below?
const string DEFAULT_HOST = "localhost"
This would make them more easy to find and change.
Would a class also be a good way to modularise this information? There would only be one argument when passing these arguments into methods.
| { | ||
| public class Program | ||
| { | ||
| public static async Task Main(string[] args) |
There was a problem hiding this comment.
I believe splitting main into many smaller methods that are all called in main could lead to more modularity and better readability.
csharp/example/Program.cs
Outdated
| string query = "SELECT city, loc[0] AS longitude, loc[1] AS latitude, pop, state, _id FROM Samples.\"samples.dremio.com\".\"zips.json\" LIMIT 100"; | ||
| string protocol = "http"; | ||
|
|
||
| // Parse command-line arguments to override the defaults when set |
There was a problem hiding this comment.
Parsing the command line arguments should fall into a static private method.
csharp/example/Program.cs
Outdated
| // Parse command-line arguments to override the defaults when set | ||
| for (int i = 0; i < args.Length-1; i++) | ||
| { | ||
| if (i % 2 == 0 && args[i].StartsWith("-")) |
There was a problem hiding this comment.
This logic assumes that the user will use the command flags correctly. I think a more robust algorithm would be to:
- Have the method for parsing the command line arguments return a Dictionary <string, string> that has the keys being the command line flags and the values being the value of the flag.
- When creating the Dictionary, have the initial values be the default values of the flags
- Loop through the arguments list by each argument
- Have a null string lastFlag to keep track of the previous command flag
- Go through the following control structure for each argument:
// Skip if is null or white space
if (string.IsNullOrWhiteSpace(argument))
{
continue;
}
// Add argument to lastFlag if starts with -
if (argument.StartsWith("-", StringComparison.Ordinal))
{
lastFlag = argument;
}
// If lastFlag is not null, save the
else if (lastFlag != null && optionsDic.ContainsKey(lastFlag))
{
commandLineArguments.Add(lastFlag, argument);
lastFlag = null;
}
- Return the dictionary
csharp/example/Program.cs
Outdated
| } | ||
| } | ||
|
|
||
| // Basic auth using username and password |
There was a problem hiding this comment.
Creating a separate method for this would modularise and make the code more legible.
csharp/example/Program.cs
Outdated
| string encoded = System.Convert.ToBase64String(System.Text.Encoding.GetEncoding("ISO-8859-1").GetBytes(user + ":" + pass)); | ||
| Console.WriteLine($"The encoded credentials: {encoded}"); | ||
|
|
||
| // Create client |
There was a problem hiding this comment.
Creating a separate method for this would modularise and make the code more legible.
csharp/example/Program.cs
Outdated
| Console.WriteLine($"Connecting to: {address}"); | ||
|
|
||
| var handler = new HttpClientHandler(); | ||
| // For localhost https (TLS) endpoint testing, uncomment the following to avoid a cert error |
There was a problem hiding this comment.
Creating a separate option to disable certificate validation would be more user friendly - the control structure for the arguments list would have to be modified slightly to accept a flag with no value.
csharp/example/Program.cs
Outdated
|
|
||
| FlightClient client = new FlightClient(channel); | ||
|
|
||
| // Pass the query text as the Command Descriptor |
There was a problem hiding this comment.
Creating a separate method for this would modularise and make the code more legible.
|
Thanks for reviewing @ArgusLi -- I will plan to make this more than just a simple example then :-) |
|
Created a number of functions and added a generic command-line args parser |
2 participants
Adding this C# example based on a few requests for this in stackoverflow. This is just an example to show connecting to Dremio and run a query.