Add devcontainers support to the repository #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is mostly based on https://github.com/vandop/dremio-personal-analytics/ with some minor changes. We could think about kicking out Apache superset since most developers are probably not going to need it. There should also be an easy way to replace the oss dremio container with a self-hosted enterprise version if we're working on an enterprise-only feature. |
simonpannek
force-pushed
the
dbt-dremio-dev-containers
branch
from
fdbcaae to
205f53b
Compare
bcmeireles
reviewed
Jan 24, 2025
99Lys
previously approved these changes
Jan 25, 2025
There was a problem hiding this comment.
Great PR! I've compared with https://github.com/vandop/dremio-personal-analytics/ and saw the changes you made, they make sense to me
99Lys
approved these changes
Feb 12, 2025
bcmeireles
approved these changes
Feb 12, 2025
howareyouman
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to introduce devcontainer support to this repository. With this addition, developers will be able to quickly set up and run a dockerized environment in VSCode, GitHub Codespaces, or any other platform that supports devcontainers.
Changelog