Merge pull request #847 from dresende/security_and_node_11

Resolve lodash security issues & add node 11+ support
dresende · Nov 4, 2019 · f4ac6ee · f4ac6ee
2 parents 40d349f + d907924
commit f4ac6ee
Show file tree

Hide file tree

Showing 7 changed files with 590 additions and 168 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -5,8 +5,12 @@ node_js:
   - '6'
   - '8'
   - '10'
+  - '12'
+  - '13'
 before_script:
   - mysql -e 'create database orm_test;'
   - psql -c 'create database orm_test;' -U postgres
 services:
   - mongodb
+  - mysql
+  - postgresql
diff --git a/Changelog.md b/Changelog.md
@@ -1,11 +1,15 @@
+### v5.0.5
+- Update lodash & sql-ddl-sync version to address security vulnerabilities ([845](../../pull/845)
+- Node 11+ support (stable sort; see https://github.com/nodejs/node/issues/24294 for details)
+- Test against node 12 & 13
+
 ### v5.0.4
 - Update sql-query version to address security vulnerabilities ([841](../../pull/841)
 
 ### v5.0.3
 - Update dependencies to address security vulnerabilities
 
 ### v5.0.2
-
 - Fix rare crash when object slips into postgres `escapeValue` ([dresende/node-sql-query#54](https://github.com/dresende/node-sql-query/pull/54)) ([#833](../../pull/833))
 
 ### v5.0.1

diff --git a/lib/ChainInstance.js b/lib/ChainInstance.js
@@ -42,8 +42,8 @@ function ChainInstance(chain, cb) {
 
       return next();
     }),
-    sort: promise(function (cb) {
-      instances.sort(cb);
+    sort: promise(function (sortFn) {
+      instances.sort(sortFn);
 
       return next();
     }),