Promise support #807
Merged
Promise support #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some changes from tests
Feature/lm 2606 Add Promise documentation
dxg
requested changes
Sep 18, 2017
lib/ChainFind.js
Outdated
| promise.handle(this.all); | ||
| } | ||
| return promise.fail(cb); | ||
| }, |
There was a problem hiding this comment.
I recommend we keep these in the code, and just add a console.warn deprecation message & mention deprecation in changelog
…ivers Fixed failed mysql tests
…ivers skip eagerQuery test for redshift
…ivers Fix/lm 2855 fix tests for all drivers
…ivers fix duplication
…ivers fix indentation
…ivers fix duplication
|
Awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Promise support for all possible ORM methods. For more info read
Readme, Promise chapter.