Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#29] Updated to scaffold 0.12.1. #32

Merged

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Feb 19, 2024

Checklist before requesting a review

closes #29

  • I have formatted the subject to include ticket number
    as [PRJ-123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was
    done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and
    they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

Copy link
Member

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannguyen04
Copy link
Contributor Author

@tannguyen04 Please revert changes done to the BehatCliContext.php file and exclude it from Rector

https://github.com/drevops/behat-format-progress-fail/pull/32/files#diff-21c4e0fe021a3527cb2e5966f57f6fb3ade1deb09e9edebb63fd1f098f375678L14

Hi @AlexSkrypnyk
I have updated PR as your request.

@AlexSkrypnyk AlexSkrypnyk merged commit 27658da into drevops:main Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Scaffold 0.12
2 participants