Skip to content

Conversation

@anastasiabusygina
Copy link

No description provided.

Copilot AI review requested due to automatic review settings November 27, 2025 20:08
Copilot finished reviewing on behalf of anastasiabusygina November 27, 2025 20:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relaxes the protobuf dependency version constraint from an exact pin (5.29.2) to a caret version (^5.29.2), allowing minor and patch version updates within the 5.x series while maintaining the same major version.

  • Changes the protobuf version specification from exact pin to caret range

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

deprecated = "^1.2.14"
events = "^0.5"
numpy = "^1.26.2"
grpcio = "1.68.1"
Copy link

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The protobuf version constraint is being relaxed while grpcio remains pinned to an exact version. The generated protobuf code in geyser_pb2.py was created with protobuf 5.28.1 and includes runtime version validation (line 12-19 in geyser_pb2.py). Consider also relaxing the grpcio version pin to use a caret constraint (e.g., "^1.68.1") for consistency, as grpcio and protobuf are closely related dependencies that typically work together across minor versions.

Suggested change
grpcio = "1.68.1"
grpcio = "^1.68.1"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant