Send negative response when the sub-function is missing #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Services that require a sub-function do not currently return a negative response when the sub-function is missing from the request. This fix removes the length check from evaluateServiceResponse() and relies on the fact that the length checks are implemented correctly in the service callbacks. Also re-ordered the switch statement to make it clearer which services aren't implemented. In reality these services will never be checked in the switch stattement as getServiceForSID() will return NULL and trigger an early exit. Signed-off-by: Mark Corbin <mcorbin@lunarenergy.com>
driftregion
added
the
unit-test-wanted
|
Looks good to me, thanks Mark! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services that require a sub-function do not currently return a negative response when the sub-function is missing from the request. This fix removes the length check from evaluateServiceResponse() and relies on the fact that the length checks are implemented correctly in the service callbacks.
Also re-ordered the switch statement to make it clearer which services aren't implemented. In reality these services will never be checked in the switch stattement as getServiceForSID() will return NULL and trigger an early exit.