feat: Support multiple patterns and files, improve CLI #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces several major features and refactors the codebase for better flexibility and performance. Features: - Multiple search patterns: Allows specifying multiple search patterns from the command line. - Multiple input files: The CLI now accepts multiple input files, separated by `--`. - Graceful shutdown: Uses `context.Context` to handle interruptions (like Ctrl+C) gracefully. - Improved CLI argument parsing: Migrated from `kingpin` to `cobra` to support more complex argument structures, like separating patterns from file paths with `--`. Refactoring: - Decoupled processing: Introduced `LineProcessor` and `FilesProcessor` to separate concerns of line-level matching and file-level iteration. - Simplified file processing: The `FilesProcessor` is currently implemented with a single-threaded design for simplicity. - Efficient I/O: A `BufferedFileOpener` has been added to improve file reading performance. - Code organization: The logic from the deleted `printer.go` has been consolidated into the new `lines_processor.go`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several major features and refactors the codebase for better flexibility and performance.
Features:
--.context.Contextto handle interruptions (like Ctrl+C) gracefully.kingpintocobrato support more complex argument structures, like separating patterns from file paths with--.Refactoring:
LineProcessorandFilesProcessorto separate concerns of line-level matching and file-level iteration.FilesProcessoris currently implemented with a single-threaded design for simplicity.BufferedFileOpenerhas been added to improve file reading performance.printer.gohas been consolidated into the newlines_processor.go.