Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate kernel for more comprehensive keyboard inputs and other layout variations (inspired from previous work by NotKit and nsensfel) #2

Open
wants to merge 2 commits into
base: droidian
Choose a base branch
from

Conversation

Kabouik
Copy link

@Kabouik Kabouik commented May 9, 2024

This has not been tested, but is an attempt at merging @nsensfel PR #1 for F1-F12 keys on Fn + digits row, and @NotKit's commits to the SFOS kernel to move / and ? to the Sym key and remap Yellow arrows to RIGHT_ALT.

This deviates from the key labels, but has significant pros that some users may prefer: more keys for desktop applications, sometimes very important, and Yellow arrows become a real modifier that can be chorded with other keys, for more keybinds in Phosh or an embedded WM. Being replicated on both sides of the keyboard, this adds many handy keybinds (see droidian/droidian#7).

Both patches are kind of incompatible, since @nsensfel's PR needs a Fn modifier, and @NotKit's changes remove default Fn keys by making Yellow arrows act as RIGHT_ALT. Therefore, I tried to remap the Yellow F button as Fn instead of Super/Meta (in NotKit commits) or ISO_Level3_Shift (Droidian default). With Fn allowing things like F1-F12 or Home, End, PgUp and PgDn, I feel it is more useful than a standard modifier available only on one side of a thumb keyboard.

Thinking about it now, I'm wondering if Yellow arrows should not be made Super/Meta (keycode 125) instead of RIGHT_ALT (100). I guess that only matters for programs that expect one and don't allow rebindings shortcuts.

I don't think I have the setup in place for compiling the kernel according to the porting documentation and trying this out, so I'm posting it here in the mean time. Comments welcome, especially if you think the commits are broken (not sure about the addition of oeml and oemr for instance).

@Kabouik
Copy link
Author

Kabouik commented May 9, 2024

Note that if remapping Yellow F to Fn worked, then we can edit this line to make Fn + P = / and Fn + L = ? again, even if duplicate with /? on Sym, to avoid the mismatch with key labels there, for users who would not know about the Sym change.

But I think this should be tried as is first, see if the current changes even work.

@Kabouik Kabouik changed the title Remap arrow keys to Alt R, Fx key to Fn (inspired from NotKit's patch on SFOS), F1-12 on Fn + digits row (from nsensfel's PR #1) Remap arrow keys to Super/Meta, Fx key to Fn (inspired from NotKit's patch on SFOS), F1-12 on Fn + digits row (from nsensfel's PR #1) May 15, 2024
@Kabouik Kabouik changed the title Remap arrow keys to Super/Meta, Fx key to Fn (inspired from NotKit's patch on SFOS), F1-12 on Fn + digits row (from nsensfel's PR #1) Remap arrow keys to Super/Meta, Fx key to Fn and Syn to /? (inspired from NotKit's patch on SFOS), F1-12 on Fn + digits row (from nsensfel's PR #1) May 15, 2024
@Kabouik Kabouik changed the title Remap arrow keys to Super/Meta, Fx key to Fn and Syn to /? (inspired from NotKit's patch on SFOS), F1-12 on Fn + digits row (from nsensfel's PR #1) Remap arrow keys to Super/Meta, Fx key to Fn and Syn to /? (inspired from NotKit's patch on SFOS), Fn + digits row to F1-12 (from nsensfel's PR #1), and add system or media keys to Fn + other keys where Shift would already print the secondary symbol May 15, 2024
@Kabouik Kabouik force-pushed the droidian branch 2 times, most recently from 6e7cf83 to aac3959 Compare May 16, 2024 00:53
@Kabouik
Copy link
Author

Kabouik commented May 16, 2024

The PR does this on the Pro1 QWERTY version:

  • The special Yellow F key becomes Fn and other keys get more Fn functions (F1-F12, system functions like bbrightness, volume or airplane, etc., shown in yellow prints in the image),
  • Yellow arrows become Super/Meta, and therefore open possible keybinds with any other key on the keyboard using both thumbs (used in Phosh, embedded WMs, applications),
  • Sym becomes /, ? when combined with Shift, and ISO_Level3_Shift when combined with Fn (also referred to as Alt Gr in Europe) ; the latter is not convenient to press but may still be useful to ius-intl users, consider maybe moving that modifier to Fn + Alt,
  • L and P retain the symbols ? and /, respectively, when combined with Fn, to make those characters easy to type even for users not aware that they are more easily used with the Sym key,
  • All other keys with a yellow print can be chorded with Shift to compose that character, like on standard keyboards
  • Some functions seem to have no effect, but don't hurt (Play/Pause, Scroll Lock, Insert…),
  • no change on the QWERTZ version because I would not be able to test.

@Kabouik Kabouik changed the title Remap arrow keys to Super/Meta, Fx key to Fn and Syn to /? (inspired from NotKit's patch on SFOS), Fn + digits row to F1-12 (from nsensfel's PR #1), and add system or media keys to Fn + other keys where Shift would already print the secondary symbol Alternate kernel for more comprehensive keyboard inputs and other layout variations (inspired from previous work by NotKit and nsensfel) May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant