feat: [CI-14390]: Added new enhancements to plugins/jira
#26
Conversation
vanisrikanithi
changed the title
plugin/plugin.go
Outdated
| State: state, | ||
| UpdateSequenceNumber: args.Build.Number, | ||
| References: []struct { |
There was a problem hiding this comment.
add a check to make sure the branch and URI values exist before adding them to the References so it'll only be added when the necessary values are available
plugin/plugin.go
Outdated
| if len(args.IssueKeys) > 0 { | ||
| issues = args.IssueKeys | ||
| } else { | ||
| issue = extractIssue(args) | ||
| if issue == "" { | ||
| logger.Debugln("cannot find issue number") | ||
| return errors.New("failed to extract issue number") | ||
| } | ||
| logger = logger.WithField("issue", issue) | ||
| } |
There was a problem hiding this comment.
let's not duplicate how we handle both the array (issues) and the single issue (issue [old logic]) separately, and keep the logic simple:
// check if PLUGIN_ISSUEKEYS is provided
if len(args.IssueKeys) > 0 {
issues = args.IssueKeys
} else {
// fallback to extracting from commit if no issue keys are passed
issue = extractIssue(args)
if issue == "" {
logger.Debugln("cannot find issue number")
return errors.New("failed to extract issue number")
}
issues = []string{issue} // add the single issue here for consistency
}
and modify the deployment payload accordingly.
There was a problem hiding this comment.
Initially I have done this way, but observed one issue that if PLUGIN_ISSUEKEYS are not provided then Issue keys will be populated by old way(extractIssue) right. That means deployment payload contains always both Issuekeys and associations like below. With this payload when i tested restapi (postman) I was getting error in the response as below ("message": "issueKeys and associations are mutually exclusive.) Is this expected.? Also it could be existing behaviour. It won't cause any issue?
Request chunk:
"issueKeys": [
"SCRUM-1"
],
"associations": [
{
"associationType": "issueIdOrKeys",
"values": [
"SCRUM-1"
]
}
],
Response chunk:
"errors": [
{
"message": "issueKeys and associations are mutually exclusive. Either only specify issueKeys or pass issueKeys as an associationType.",
"key": "deploymentdata.issueKeysOrAssociationsOrNone.invalid"
},
Ompragash
changed the title
plugins/jira
util_test.go updated with unit tests for new functions. In plugin.go not implemented any new
|
|
Review comments addressed and updated the new patch. |
plugin/plugin.go
Outdated
| if len(args.IssueKeys) > 0 { | ||
| deploymentPayload.Deployments[0].Associations = nil | ||
| } | ||
| /*fmt.Println("formatted deploymentPayload JSON data") |
There was a problem hiding this comment.
remove this comment please. Please make sure those debug/temp/commented out code doesn't appear in final PR
plugin/util.go
Outdated
| } | ||
| } else { | ||
| // Log the error if URL parsing fails | ||
| log.Printf("Error parsing URL '%s': %v", instance, err) |
There was a problem hiding this comment.
consider using the logger like logrus to maintain consistency across the plugin
…rus for printing log messages
|
@Ompragash @jamie-harness I have addressed the review comments. Please take a look at the latest changes. |
This review covers all Jira issues #21,#22,#23,#24 as per jira spec.
There are some commented lines which are used for debugging. once the review is approved, will remove them.