Skip to content

Include Bluetooth metadata to parsing exceptions #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2024
Merged

Include Bluetooth metadata to parsing exceptions #36

merged 2 commits into from
Jul 19, 2024

Conversation

matejglejtek
Copy link
Contributor

@matejglejtek matejglejtek commented Jul 18, 2024 •
edited
Loading

Throw ODIDMessageParsingException when parsing of odid message fails. The exception contains metadata such as mac address, bluetooth name, rssi, timestamp, source.

Add missing bluetooth name to ODIDPayload.

Example in Sentry: APP-2HZ.

After this will be merged I will use it in app: https://github.com/dronetag/app/pull/411.

@matejglejtek
feat: add bt name to ODIDPayload
4683e23 
 read from ScanResult and CBPeripheral

DT-3048
@matejglejtek
feat: add ODIDMessageParsingException
715e231 
throw when parsing fails

DT-3038
@matejglejtek matejglejtek force-pushed the feat/DT-3048-parsing-exception branch from d308b27 to 715e231 Compare July 18, 2024 15:24
@marianhlavac marianhlavac changed the title feat: add parsing exception Include Bluetooth metadata to parsing exceptions Jul 19, 2024
marianhlavac
marianhlavac approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@marianhlavac marianhlavac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, much better than changing Sentry contexts, and in the end much more useful – when debugging locally and observing a parsing exceptions, you automatically get much more data in the exception object. Great job!

@matejglejtek matejglejtek merged commit 89a29b6 into master Jul 19, 2024
1 check passed
@matejglejtek matejglejtek deleted the feat/DT-3048-parsing-exception branch July 19, 2024 07:39
marianhlavac pushed a commit that referenced this pull request Jul 19, 2024
@semantic-release-bot
chore(release): Release 0.19.0
4af7ce5 
# [0.19.0](v0.18.1...v0.19.0) (2024-07-19)

### Features

* add bt name to ODIDPayload ([4683e23](4683e23))
* add ODIDMessageParsingException ([715e231](715e231))
* include Bluetooth metadata to parsing exceptions ([#36](#36)) ([89a29b6](89a29b6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marianhlavac marianhlavac marianhlavac approved these changes

@albertmoravec albertmoravec albertmoravec approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejglejtek @marianhlavac @albertmoravec