Skip to content

refactor: split message event channels for wifi and bt #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

matejglejtek
Copy link
Contributor

Refactor FlutterOpendroneId API for the DroneScanner 2.0.

I created 2 event channels, one for bt and one for wifi. Now there are 2 streams, 1 for each technology.
I also refactored start/stop methods, so it is possible to control wifi/bt separately.

@matejglejtek matejglejtek changed the title refactor: split message event channels to wifi and bt refactor: split message event channels for wifi and bt Nov 22, 2024
@matejglejtek matejglejtek force-pushed the refactor/split-wifi-bt branch from 68b7e98 to e08d293 Compare November 22, 2024 10:11
@matejglejtek matejglejtek force-pushed the refactor/split-wifi-bt branch from e08d293 to 1766577 Compare November 22, 2024 13:12
Copy link
Contributor

@albertmoravec albertmoravec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any changes for Android support?

@matejglejtek
Copy link
Contributor Author

matejglejtek commented Nov 24, 2024

Do we need any changes for Android support?

Nope, changes in this PR should be sufficient. I added stream handlers for new event channels to android/ios code. Stream handlers are passed to bt/wifi scanners.

@matejglejtek matejglejtek merged commit e947be1 into master Nov 26, 2024
1 check passed
@matejglejtek matejglejtek deleted the refactor/split-wifi-bt branch November 26, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants