Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit intervals and datasource #310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cosmic-chichu
Copy link

To maintain parity between druid clients such as go-druid and pydruid we need to express the intervals and datasource explicitly or in the fully expanded native query form.

@ssriramu
Copy link

@gianm would really appreciate your help with reviewing and merging this change?

@gianm
Copy link
Member

gianm commented Dec 1, 2023

It looks like the patch replaces the short form of table and intervals with long form, but, I'm wondering why this is necessary?

@cosmic-chichu
Copy link
Author

Since the short form produces a query that is not parseable using other Druid clients such as go-druid. Keeping it in the long form helps with disambiguation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants