Skip to content

Conversation

@MurzNN
Copy link

@MurzNN MurzNN commented Jan 11, 2021

Here is workaround for fix errors with BigInt Drupal field types (Integer with size = big).
Now those fields are represented as 32-bit integer in GraphQL, and throw the error, when value is larger than 32-bit, with inserting null in result.
This workaround is replacing Integer GraphQL field type to String for those field types, to fix described problem.
Closes #1130

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #1143 (aba5d87) into 8.x-3.x (8418bb7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             8.x-3.x    #1143      +/-   ##
=============================================
+ Coverage      78.72%   78.73%   +0.01%     
- Complexity      1139     1141       +2     
=============================================
  Files            192      192              
  Lines           3027     3029       +2     
=============================================
+ Hits            2383     2385       +2     
  Misses           644      644              
Impacted Files Coverage Δ Complexity Δ
...e/src/Plugin/Deriver/Fields/EntityFieldDeriver.php 96.66% <100.00%> (+0.23%) 11.00 <0.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8418bb7...aba5d87. Read the comment docs.

@klausi klausi added the 3.x label Jan 12, 2021
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (8418bb7) to head (aba5d87).
Report is 38 commits behind head on 8.x-3.x.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             8.x-3.x    #1143      +/-   ##
=============================================
+ Coverage      78.72%   78.73%   +0.01%     
- Complexity      1139     1141       +2     
=============================================
  Files            192      192              
  Lines           3027     3029       +2     
=============================================
+ Hits            2383     2385       +2     
  Misses           644      644              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants