Correct normalizations #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
countvajhula
had a problem deploying
to
test-env
GitHub Actions
Failure
29 tasks
|
If I have time today I'll confirm this fixes my AoC tests. |
benknoble
approved these changes
Dec 14, 2023
countvajhula
force-pushed
the
lets-write-a-qi-compiler
branch
from
3690ebf to
e34f5ae
Compare
|
Thanks for verifying! |
countvajhula
force-pushed
the
correct-normalization
branch
from
757ff29 to
9d5290e
Compare
|
There were a few compiler tests that were failing for the old rules. I guess this proves that our compiler tests are working 😄 |
countvajhula
merged commit 45c52fa
into
drym-org:lets-write-a-qi-compiler
1 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Address review by @benknoble on the compiler PR re: the soundness of normalizations.
Public Domain Dedication