Make custom potion effects check less agressive

ds58 · Mar 5, 2024 · 8a860e8 · 8a860e8
1 parent 7e12b79
commit 8a860e8
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 1 deletion.
diff --git a/api/src/main/java/com/ruinscraft/panilla/api/nbt/checks/NbtCheck_CustomPotionEffects.java b/api/src/main/java/com/ruinscraft/panilla/api/nbt/checks/NbtCheck_CustomPotionEffects.java
@@ -3,6 +3,8 @@
 import com.ruinscraft.panilla.api.IPanilla;
 import com.ruinscraft.panilla.api.config.PStrictness;
 import com.ruinscraft.panilla.api.nbt.INbtTagCompound;
+import com.ruinscraft.panilla.api.nbt.INbtTagList;
+import com.ruinscraft.panilla.api.nbt.NbtDataType;
 
 public class NbtCheck_CustomPotionEffects extends NbtCheck {
 
@@ -12,7 +14,43 @@ public NbtCheck_CustomPotionEffects() {
 
     @Override
     public NbtCheckResult check(INbtTagCompound tag, String itemName, IPanilla panilla) {
-        return NbtCheckResult.FAIL;
+        String using = null;
+
+        if (tag.hasKey(getName())) {
+            using = getName();
+        } else {
+            for (String alias : getAliases()) {
+                if (tag.hasKey(alias)) {
+                    using = alias;
+                }
+            }
+        }
+
+        if (using == null) {
+            throw new IllegalStateException("Unknown custom potion effects tag");
+        }
+
+        INbtTagList effectsList = tag.getList(using, NbtDataType.COMPOUND);
+
+        for (int i = 0; i < effectsList.size(); i++) {
+            INbtTagCompound effect = effectsList.getCompound(i);
+
+            if (effect.hasKeyOfType("amplifier", NbtDataType.BYTE)) {
+                short amplifier = effect.getByte("amplifier");
+                if (amplifier > 32) {
+                    return NbtCheckResult.CRITICAL;
+                }
+            }
+
+            if (effect.hasKeyOfType("Amplifier", NbtDataType.BYTE)) {
+                short amplifier = effect.getByte("Amplifier");
+                if (amplifier > 32) {
+                    return NbtCheckResult.CRITICAL;
+                }
+            }
+        }
+
+        return NbtCheckResult.PASS;
     }
 
 }
diff --git a/api/src/main/java/com/ruinscraft/panilla/api/nbt/checks/NbtCheck_EntityTag.java b/api/src/main/java/com/ruinscraft/panilla/api/nbt/checks/NbtCheck_EntityTag.java
@@ -248,6 +248,13 @@ private static NbtCheckResult checkEffectsTag(INbtTagList effectsList) {
                     return NbtCheckResult.CRITICAL;
                 }
             }
+
+            if (effect.hasKeyOfType("Amplifier", NbtDataType.BYTE)) {
+                short amplifier = effect.getByte("Amplifier");
+                if (amplifier > 32) {
+                    return NbtCheckResult.CRITICAL;
+                }
+            }
         }
 
         return NbtCheckResult.PASS;