Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

feat: support ask image for async mode #137

Merged
merged 1 commit into from
Jul 24, 2023
Merged

feat: support ask image for async mode #137

merged 1 commit into from
Jul 24, 2023

Conversation

yihong0618
Copy link
Contributor

This PR do these things as follows:

  • make a common file that the function can use both async and sync modes
  • support ask_about_image for async mode
  • clean some code

next will do make all async sync mode the same api

@gitguardian
Copy link

gitguardian bot commented Jul 24, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Base64 Basic Authentication a0df7c6 bardapi/common.py View secret
- Base64 Basic Authentication a0df7c6 bardapi/constants.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@dsdanielpark dsdanielpark merged commit d79895e into dsdanielpark:main Jul 24, 2023
@dsdanielpark
Copy link
Owner

dsdanielpark commented Jul 24, 2023

yihong0618
Thank you for your contribution.

I have made some refactoring based on the code you provided.
There still seems to be room for improvement, but I currently have limited time due to other project work.

(By the way, I've decided to give up on purchasing the Xiaomi AI speaker in Korea due to difficulties in finding various Xiaomi products here. The XMYX04WM model is almost the only option that I can buy in Korea. After reviewing the code, I felt hesitant to purchase more speakers, considering the uncertainty of Korean language support in some steps on xiaogpt. Nevertheless, I appreciate you showing me that fantastic project.)

@yihong0618
Copy link
Contributor Author

@dsdanielpark thanks, If I find a way to support XMYX04WM, will info you~

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants