This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
Ensure the order of image urls #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your thoughtful insights and revisions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed the type of the "images" variable from set to list, to ensure the order of urls.
I encountered a problem of inconsistency of the order of images so I made this change.
*adding to the change above, I fixed a wrong description of a type of "images" response in ask_about_image().
Related Issue
#178
Motivation and Context
I encountered the problem when I tried to match the image descriptions in the reponse and image urls.
How Has This Been Tested?
I tested the get_answer() function with my machine below.
Screenshots (if appropriate):
Thank you once again to all the contributors. Your efforts are greatly appreciated!