[TEST] add DualConv Module for testing of multi node outputs#41
[TEST] add DualConv Module for testing of multi node outputs#41advikasinha wants to merge 2 commits intomainfrom
Conversation
|
could've added bit detailed description of the PR :) nvm i'll go through the codes once |
|
This PR added support for multi-output nodes in the DL-Playground diagram editor and code generator. A sample
Changes1. New Node: DualOutputConv (
|
|
test-comment |
There was a problem hiding this comment.
how are we deciding when to use conv_out or flat_out shape, is it based on the target node type?
| } | ||
|
|
||
| // Return per-handle shapes | ||
| static shapeCompute( |
There was a problem hiding this comment.
will this shapeCompute each time calculate both flat_out and conv_out and in future if we extend to other nodes , isn't this a suboptimal approach, can we use something like based on the targetNode type decide what shape to compute?
There was a problem hiding this comment.
Did you make changes in shape_verifier.ts are we making sure that shapeVerifier passes correct shapes byHandle to inputShapes it seems we are only passing defaultShape?
Line 80 in shape_verifier.ts
const inputShapes = inputIds.map(src => shapes[src]?.defaultShape || []);
| ], | ||
| }; | ||
|
|
||
| static shapeVerifier(data: DualOutputConvData, inputShapes: number[][]) { |
There was a problem hiding this comment.
are we not checking in_channel, out_channel and things like stride validation for shape? right now we are just checking 2 conditions it seems
- Length!=0 (empty)
- shape has to be 4D
am i missing something or is it fine?
Missing maybe:
- kernel and stride check
- in_channels and input channel matching check
You can refer to how we have done in conv2d.tsx

No description provided.