fix: use INVOKE_PROPERTYPUT for SAFEARRAY (#323)

dspace-group · Jan 3, 2025 · 37c5e86 · 37c5e86
1 parent 478458d
commit 37c5e86
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/dscom.test/tests/PropertyTest.cs b/src/dscom.test/tests/PropertyTest.cs
@@ -100,7 +100,7 @@ public void PropertyInInterfaceWithComInterface_ShouldHavePutRef()
     [InlineData(typeof(bool), INVOKEKIND.INVOKE_PROPERTYPUT)]
     [InlineData(typeof(char), INVOKEKIND.INVOKE_PROPERTYPUT)]
     [InlineData(typeof(object), INVOKEKIND.INVOKE_PROPERTYPUTREF)]
-    [InlineData(typeof(object[]), INVOKEKIND.INVOKE_PROPERTYPUTREF)]
+    [InlineData(typeof(object[]), INVOKEKIND.INVOKE_PROPERTYPUT)]
     [InlineData(typeof(System.Collections.IEnumerator), INVOKEKIND.INVOKE_PROPERTYPUTREF)]
     [InlineData(typeof(DateTime), INVOKEKIND.INVOKE_PROPERTYPUT)]
     [InlineData(typeof(Guid), INVOKEKIND.INVOKE_PROPERTYPUT)]

diff --git a/src/dscom/writer/PropertySetMethodWriter.cs b/src/dscom/writer/PropertySetMethodWriter.cs
@@ -37,9 +37,9 @@ public override void Create()
                      return true;
                  }
 
-                 // every class except special ones (e.g. String)
+                 // every class except special ones (e.g. String) or SAFEARRAY
                  // are handles as references
-                 if (type.IsClass && !type.IsSpecialHandledClass())
+                 if (type.IsClass && !type.IsSpecialHandledClass() && !type.IsArray)
                  {
                      return true;
                  }