Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring availability zones #2266

Merged
merged 15 commits into from
Feb 11, 2025
Merged

Allow configuring availability zones #2266

merged 15 commits into from
Feb 11, 2025

Conversation

r4victor
Copy link
Collaborator

@r4victor r4victor commented Feb 5, 2025

Closes #2107

The PR:

  • Adds availability_zones parameter to profiles, run, and fleet configurations.
  • Adds availability_zone parameter to volume configurations.
  • Supports custom availability zones for AWS, GCP, OCI.
  • Shows availability zones in dstack fleet -v and dstack volumes -v.
  • Fixes missing backward compatibility handling (run_spec excludes) for /runs/apply – led to broken in-place updates.

@r4victor r4victor requested review from jvstme and un-def February 5, 2025 12:28
jvstme
jvstme reviewed Feb 6, 2025
View reviewed changes
src/dstack/_internal/cli/utils/fleet.py Outdated Show resolved Hide resolved
src/dstack/_internal/core/backends/aws/compute.py Outdated Show resolved Hide resolved
src/dstack/_internal/core/backends/aws/resources.py Outdated Show resolved Hide resolved
src/dstack/_internal/core/backends/gcp/resources.py Outdated Show resolved Hide resolved
@r4victor
Copy link
Collaborator Author

@jvstme, added InstanceOfferWithAvailability.availability_zones and updated get_offers for AWS, GCP, OCI as you suggested. OCI get_offers went for me from ~14s to ~20s. Other backends' times are not affected.

@r4victor r4victor requested a review from jvstme February 10, 2025 08:07
jvstme
jvstme approved these changes Feb 10, 2025
View reviewed changes
src/dstack/_internal/core/backends/oci/resources.py Outdated Show resolved Hide resolved
src/dstack/_internal/core/backends/gcp/compute.py Outdated Show resolved Hide resolved
src/dstack/_internal/core/backends/gcp/compute.py Show resolved Hide resolved
src/dstack/_internal/core/backends/oci/compute.py Outdated Show resolved Hide resolved
@r4victor r4victor merged commit b92caf5 into master Feb 11, 2025
24 checks passed
@r4victor r4victor deleted the issue_2107_availability_zones branch February 11, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvstme jvstme jvstme approved these changes

@un-def un-def Awaiting requested review from un-def

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Availability zones in configurations
2 participants
@r4victor @jvstme