Allow configuring availability zones #2266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvstme
reviewed
Feb 6, 2025
jvstme
reviewed
Feb 7, 2025
|
@jvstme, added InstanceOfferWithAvailability.availability_zones and updated get_offers for AWS, GCP, OCI as you suggested. OCI get_offers went for me from ~14s to ~20s. Other backends' times are not affected. |
jvstme
approved these changes
Feb 10, 2025
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 4, 2025
* Allow specifying availability_zones for fleets and runs * Allow specifying availability_zone for volumes * Fix tests * Filter out invalid zones for AWS and GCP * Support availability_zones for OCI * Display fleets and volumes availability zones in the CLI * Fix tests * Handle availability_zones backward compatibility for runs, fleets, volumes * Add InstanceOfferWithAvailability.availability_zones * Refactor fleet and volume tables to use add_row_from_dict * Minor fixes * Review fixes
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 5, 2025
* Allow specifying availability_zones for fleets and runs * Allow specifying availability_zone for volumes * Fix tests * Filter out invalid zones for AWS and GCP * Support availability_zones for OCI * Display fleets and volumes availability zones in the CLI * Fix tests * Handle availability_zones backward compatibility for runs, fleets, volumes * Add InstanceOfferWithAvailability.availability_zones * Refactor fleet and volume tables to use add_row_from_dict * Minor fixes * Review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2107
The PR:
availability_zonesparameter to profiles, run, and fleet configurations.availability_zoneparameter to volume configurations.dstack fleet -vanddstack volumes -v.