Merge pull request #1 from Mythli/Mythli-patch-1

fixed custom error messages
dsternlicht · Feb 10, 2020 · 447c4f0 · 447c4f0
2 parents 0f1e523 + 7a860dc
commit 447c4f0
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/services/http.service.ts b/src/services/http.service.ts
@@ -106,11 +106,11 @@ class HttpService {
           errorMessage = dataAtPath;
         }
       }
-    } catch {}
+    } catch {} // TODO: proper handling of errors (^.^)
 
-    errorMessage = `${res.status} - ${res.statusText || ''}`;
-
-    return errorMessage;
+    return errorMessage && errorMessage.length ?
+        errorMessage :
+        `${res.status} - ${res.statusText || ''}`;
   }
 
   private async handleError(res: Response) {
@@ -149,4 +149,4 @@ class HttpService {
   }
 }
 
-export default HttpService;
+export default HttpService;