-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FeatureClassifier integration timescale and add secular timescale feature #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arison. This new method allows more flexibility for future advancements/new features without impacting the deep regressor, while decreasing computation time.
…dentical features, proper documentation to come
…e and full examples that the old feature generation method and new feature generation method yield the exact same results and are compatible to each other
…od, also isolated featureclassifier from other models such that featureclassifier.py, ClassifierSeries.py, and features.py operate together and independently from the rest of the spock system to allow changes to be made
…n since sim.copy() is not supported
… make a copy of simulation if using new rebound, this is because old rebound does not support sim.copy()
…n. Was supposed to state, fixed pool function to generate training data and removed redundant file, made it so that the training data pool runs through jupyter notebook
…fically accounted for rebound.Collision and rebound.Ejected
…ameters, removed old file
…earn 1.7 is unstable
fixed depreciating warning by updating used XGBoost version, this also decreases training time and increases performance by marginal amount. (was using 1.7, now 2.1)
…viate sklearn error
…trios, this does not effect any tests since all training/testing is done on three planet case
Included mass of star in Tsec equation so that calculations work in abstracted case, this does not effect any tests since all testing systems have a star of mass 1, this also fixes unit analysis
minor wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made multiple changes that only affect FeatureClassifier
Changes are fully implemented in commit 5c4e548, changes include:
Change comparisons, tests, and backwards compatibility
In paper_plots
commit 2a79a42 contains additional info and comparisons of:
commit 9468319 contains comparisons for old feature generation implementation verses new implementation.
commit 086be72 contains all updates except for Tsec related integration and features, this version is avalable for backwards compatibility.
Data filtration/clean data generation is done in accordance to, and with the data from, 10.5281/zenodo.14327471