Skip to content

Commit

Permalink
[MINOR][SQL] Remove signature from Hive thriftserver exception
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

Don't return expected signature to caller in Hive thriftserver exception

### Why are the changes needed?

Please see private discussion

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Existing tests

### Was this patch authored or co-authored using generative AI tooling?

No

Closes apache#43402 from srowen/HiveCookieSigner.

Authored-by: Sean Owen <srowen@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
srowen authored and dongjoon-hyun committed Oct 17, 2023
1 parent 4a0ed9c commit cf59b1f
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,7 @@ public String verifyAndExtract(String signedStr) {
LOG.debug("Signature generated for " + rawValue + " inside verify is " + currentSignature);
}
if (!MessageDigest.isEqual(originalSignature.getBytes(), currentSignature.getBytes())) {
throw new IllegalArgumentException("Invalid sign, original = " + originalSignature +
" current = " + currentSignature);
throw new IllegalArgumentException("Invalid sign");
}
return rawValue;
}
Expand Down

0 comments on commit cf59b1f

Please sign in to comment.