Livestat: A User Tool to dynamically display basekernel stats #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthain
requested changes
Apr 30, 2019
kernel/device.c
Outdated
| @@ -143,3 +159,18 @@ const char * device_name( struct device *d ) | |||
| { | |||
| return d->driver->name; | |||
| } | |||
|
|
|||
| void device_driver_get_stats(char * name, struct device_driver_stats * s) | |||
There was a problem hiding this comment.
Please factor out the matter of finding a driver by name into a separate function:
struct device_driver * device_driver_lookup( const char *name )
And then also use that in driver_open.
kernel/syscall_handler.c
Outdated
| @@ -584,6 +593,12 @@ int sys_system_rtc( struct rtc_time *t ) | |||
| return 0; | |||
| } | |||
|
|
|||
| int sys_device_driver_stats(char * name, struct device_driver_stats * stats) | |||
There was a problem hiding this comment.
const char *name and is_valid_string(name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #231
Overview
Livestat is a user lever program that is meant to display a dynamic graphic of different basekernel statistics. Version 1 allows the user to look at Buffer Cache, Process, Device Driver, and System statistics.
Testing
Statworkload was developed to test this program. Statworkload is meant to simulate different workloads and produce interesting statistics.
Bugs
On some occasions, the combination of running statworkload and livestat causes livestat to segfault.
Misc. Notes
strdup was added to library/string.c to be used in livestat. Also, data types in all stats structs were changed from u_int32s and u_int64s to ints.
Future Enhancements
In the future, additional statistics should be added. In particular, memory utilization in pages and kernel mallocs should be tracked.