Skip to content

Render an extra empty formset for a schema definition if none exist #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexbainter merged 1 commit into from
Jan 8, 2026
Merged

Render an extra empty formset for a schema definition if none exist #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ class DocumentationItemForm(ReferenceItemForm):
)


SchemaRefFormsetFactory = forms.formset_factory(SchemaRefForm, extra=0)
DocumentationItemFormsetFactory = forms.formset_factory(DocumentationItemForm, extra=0)

class SchemaForm(forms.Form):
Expand Down Expand Up @@ -135,6 +134,7 @@ def __init__(self, *args, schema = None, **kwargs):
super().__init__(*args, **kwargs)
if schema == None:
self.additional_documentation_items_formset = DocumentationItemFormsetFactory(prefix="documentation_items", *args, **kwargs)
SchemaRefFormsetFactory = forms.formset_factory(SchemaRefForm, extra=1)
self.schema_refs_formset = SchemaRefFormsetFactory(prefix="schema_refs", *args, **kwargs)
return

Expand Down Expand Up @@ -162,6 +162,9 @@ def __init__(self, *args, schema = None, **kwargs):
'name': schema_ref.name,
'url': schema_ref.url,
} for schema_ref in schema.schemaref_set.all()]
# If there aren't any schema_refs, render the formset with an extra empty formset item
extra_formset_item_count = max(1 - len(initial_schema_refs_formset_data), 0)
SchemaRefFormsetFactory = forms.formset_factory(SchemaRefForm, extra=extra_formset_item_count)
self.schema_refs_formset = SchemaRefFormsetFactory(prefix="schema_refs", initial=initial_schema_refs_formset_data, *args, **kwargs)
for schema_ref_form in self.schema_refs_formset:
schema_ref_form.schema_id = schema.id
Expand Down