Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use backtrace via generic member access #266

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Use backtrace via generic member access #266

merged 1 commit into from
Aug 31, 2022

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Aug 31, 2022

No description provided.

@dtolnay dtolnay merged commit 546342c into master Aug 31, 2022
@dtolnay dtolnay deleted the provider branch August 31, 2022 00:51
@phip1611
Copy link

phip1611 commented Aug 31, 2022 •
edited
Loading

Hi @dtolnay
Can you please give a few background information about this? Looks interesting but I have a few questions.

You refactored the code to use the error_generic_member_access feature (rust-lang/rust#99301). However, it's hard to find a high-level description of it, like what's the higher objective. Are you part of the Rust error handling team, thus, have more insights by chance?

@TimDiekmann TimDiekmann mentioned this pull request Aug 31, 2022
Merged
@TimDiekmann
Copy link

Hi @phip1611,
You probably want to look at the Provider API RFC 🙂
Error::provide uses the Provider API to return arbitrary data (i.e. Backtrace).

Repository owner locked and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtolnay @phip1611 @TimDiekmann