More robust scanning for fmt argument expressions #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error[E0277]: `PathBuf` doesn't implement `std::fmt::Display`
--> tests/test_expr.rs:105:14
|
104 | #[derive(Error, Debug)]
| ----- in this derive macro expansion
105 | #[error("{A} {b}", b = &0 as &dyn Trait<i32, A = i32>)]
| ^^^ `PathBuf` cannot be formatted with the default formatter; call `.display()` on it
|
= help: the trait `std::fmt::Display` is not implemented for `PathBuf`
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
= note: call `.display()` or `.to_string_lossy()` to safely print paths, as they may contain non-Unicode data
= note: this error originates in the macro `$crate::format_args` which comes from the expansion of the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: usage of wildcard import for enum variants
--> impl/src/scan_expr.rs:1:12
|
1 | use self::{Action::*, Input::*};
| ^^^^^^^^^ help: try: `Action::{DecDepth, Finish, IncDepth, SetState}`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_glob_use
= note: `-W clippy::enum-glob-use` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::enum_glob_use)]`
warning: usage of wildcard import for enum variants
--> impl/src/scan_expr.rs:1:23
|
1 | use self::{Action::*, Input::*};
| ^^^^^^^^ help: try: `Input::{CanBeginExpr, ConsumeAny, ConsumeBinOp, ConsumeBrace, ConsumeDelimiter, ConsumeIdent, ConsumeLifetime, ConsumeLiteral, ConsumeNestedBrace, Empty, ExpectPath, ExpectTurbofish, ExpectType, Keyword, Otherwise, Punct}`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_glob_use
This was referenced Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #335.