Add a type for representing raw-agnostic format vars #349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core::fmt format string syntax considers
format_args!("...", r#keyword = "...")
as equivalent toformat_args!("...", keyword = "...")
. That means manipulating named argument sets asSet<Ident>
using Ident's Ord impl doesn't make sense, as that impl considersr#keyword
!=keyword
.Before this PR, the following would compile successfully because thiserror would see that
fn
was already present in the user-provided named arguments, so it would not try to insert a new named argument referring to the struct field:But in contrast, the following would not compile, due to thiserror using an incorrect comparison and not realizing that a user-provided named argument for
{fn}
was already present.After this PR, both compile.