Skip to content

feat: Contrib Placeholder While Loading#11

Open
epoll31 wants to merge 4 commits intodubinc:mainfrom
epoll31:contrib-placeholder
Open

feat: Contrib Placeholder While Loading#11
epoll31 wants to merge 4 commits intodubinc:mainfrom
epoll31:contrib-placeholder

Conversation

@epoll31
Copy link
Contributor

@epoll31 epoll31 commented Apr 29, 2024

I added a placeholder for the Project Contribution images while they load.

Currently the placeholder is a light grey circle that pulses and contains the first two letters of the contributor's GitHub username.

There is also a fade in for the image when it finishes loading so that it looks better.

Here is what my fix looks like:

loading2.mov

Here is what it looked like before:

before.mov

@vercel
Copy link

vercel bot commented Apr 29, 2024

@epoll31 is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:36pm

@steven-tey
Copy link
Contributor

This is brilliant! Thank you 🙏

@epoll31
Copy link
Contributor Author

epoll31 commented May 5, 2024

Hey @steven-tey, Is there anything that I can do to help get this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants