-
Notifications
You must be signed in to change notification settings - Fork 20
Bump to v1.4.2 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump to v1.4.2 #35
Conversation
The target version update to 1.4.2 seems to be necessary to fix the `rusty_quack` loading failures that happen in extensions CI self tests, for example: ``` Failed to load 'build/release/rusty_quack.duckdb_extension', The file was built specifically for DuckDB version 'v1.4.1' and can only be loaded with that version of DuckDB. (this version of DuckDB is 'v1.4.2') ``` https://github.com/duckdb/extension-ci-tools/actions/runs/19734402684/job/56547475018?pr=268
|
Thanks! CI is failing due to this problem: duckdb/extension-ci-tools#277 Did you update extension-ci-tools to v1.4.2 too (which should include the mentioned fix)? |
|
Thanks for the review! I updated the |
|
I suggest targeting the v1.4.2 branch for this PR: But I can see the fix on main too: https://github.com/duckdb/extension-ci-tools/blob/main/makefiles/c_api_extensions/base.Makefile#L257 |
|
Changed |
|
This seems to be the cause of the failures: Updated the edit: lets see if it passes on |
I was chasing a rabbit hole about extension CI test runs from [this comment](duckdb/extension-template-rs#35 (comment)) and noticed that test runs are disabled for a few Linux configurations. I think it is possible that the reasons for disabling them there are outdated, so filing a PR to see whether these tests can be run now.
The target version update to 1.4.2 seems to be necessary to fix the
rusty_quackloading failures that happen in extensions CI self tests, for example:https://github.com/duckdb/extension-ci-tools/actions/runs/19734402684/job/56547475018?pr=268