Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing issue #4890

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix parsing issue #4890

merged 1 commit into from
Aug 12, 2024

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Aug 12, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/488551667048375/1208032966372991/f

Description

Removes the settings container object from the JSON model.

Steps to test this PR

  • Fresh install playDebug from this branch
  • Go to “Settings” > “General"
  • Verify that the “Recently Visited Sites” option is shown

Passing tests

@joshliebe Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joshliebe and the rest of your teammates on Graphite Graphite

anikiki
anikiki approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@joshliebe joshliebe merged commit 3343338 into develop Aug 12, 2024
10 checks passed
@joshliebe joshliebe deleted the feature/josh/fix-parsing-issue branch August 12, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikiki anikiki anikiki approved these changes

Assignees

@anikiki anikiki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshliebe @anikiki