Ensure autofill nightly tests succeed #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CDRussell and the rest of your teammates on |
CDRussell
commented
Oct 2, 2024
| @@ -1,9 +1,9 @@ | |||
| appId: com.duckduckgo.mobile.android | |||
| name: "Autofill: Prompted to save and update credentials on web form" | |||
| tags: | |||
| - autofillNoAuthTests | |||
| - autofillNoAuthTestsModernWebView | |||
There was a problem hiding this comment.
Changing this to prevent it from running during autofill nightlies (since Maestro Cloud emulators don't come with a modern WebView version, we can't test for actual autofill in the WebView)
There was a problem hiding this comment.
As a follow-up, do you think makes sense to skip our capabilities checks (in maestro) and run it anyways? it should work there
There was a problem hiding this comment.
I don't think I understand; if the capability checks are telling us it won't run, why would we try it in the UI test?
cmonfortep
approved these changes
Oct 2, 2024
CDRussell
deleted the
feature/craig/fix/craig/ensure_autofill_nightly_tests_succeed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/608920331025315/1208459234138716/f
Description
Autofill nightlies are failing because as of #5007, we require a more modern
WebViewthan is available in Maestro Cloud emulators.This PR:
WebViewautofill as part of the nightly (won't be possible to run this on CI until either Maestro Cloud ships their emulators with a decentWebViewversion, or we run the tests on different infrastructure)scrollUntilVisibleto help add resilience to the tests running on smaller devices or when there are extra warning/promo banners above the items we want to tap onSteps to test this PR