Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider targets for normal and experiment features #5118

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Oct 9, 2024

Task/Issue URL: https://app.asana.com/0/1198194956794324/1208490749815531/f

Description

Consider newly added (in abn) targets in normal feature and experiment features

Incidentally, I looked into the experiments and rename/documented some of the methods in there. As they were not clear to me. That's in the second commit, 6f578d9

Steps to test this PR

  • Add a different permutations of locale targets in sub-feature
  • Install the app, check targets are parsed and stored
  • Remove targets and launch app
  • Check targets change
  • Re-add targets and launch app
  • Check targets change
  • Add targets
  • Verify isEnabled() is true when targets match and false when they dont

Copy link
Collaborator Author

aitorvs commented Oct 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on Graphite Graphite

@aitorvs aitorvs force-pushed the feature/aitor/fff/targets branch 3 times, most recently from 3797574 to 6f578d9 Compare October 11, 2024 17:47
@aitorvs aitorvs marked this pull request as ready for review October 11, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants