Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing auto pixel when Duck Player set to always and navigating from YT thumbnail #5135

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add missing auto pixel when Duck Player set to always and navigating from YT thumbnail #5135

wants to merge 1 commit into from
+30 −11

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Oct 14, 2024 •
edited by anikiki
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1208529859806622/f

Description

Steps to test this PR

Always Ask + videos vertical

  • Set Duck Player to "Ask every time"
  • Search for "Dog videos"
  • Tap on a YT video from the videos carousel or videos vertical
  • Tap "Turn on Duck Player"
  • Check duckplayer_view-from_serp is fired

Always ask + organic links

  • Set Duck Player to "Ask every time"
  • Search for "Dog videos"
  • Tap on a YT video from organic links
  • Tap "Turn on Duck Player"
  • Check duckplayer_view-from_serp is fired

Always ask + overlay

Always + videos vertical

  • Set Duck Player to "Always"
  • Search for "Dog videos"
  • Tap on a YT video from the videos carousel or videos vertical
  • Check duckplayer_view-from_serp is fired

Always + organic links

  • Set Duck Player to "Always"
  • Search for "Dog videos"
  • Tap on a YT video from the videos carousel or videos vertical
  • Check duckplayer_view-from_serp is fired

Always

  • Open https://m.youtube.com/watch?v=j_saECXCoV0
  • Check duckplayer_view-from_youtube_automatic is fired
  • Tap "Watch on YouTube"
  • Scroll down to another video thumbail
  • Check duckplayer_view-from_youtube_automatic is fired

@CrisBarreiro Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

@anikiki anikiki self-assigned this Oct 14, 2024
anikiki
anikiki approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikiki anikiki anikiki approved these changes

Assignees

@anikiki anikiki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrisBarreiro @anikiki