Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: privacy stats widget #1084

Merged
merged 1 commit into from
Oct 10, 2024
Merged

ntp: privacy stats widget #1084

merged 1 commit into from
Oct 10, 2024

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Sep 25, 2024

https://app.asana.com/0/1201141132935289/1208490240844609/f

Note - This is still subject to design review, but looking to merge into main as it's not used yet, and will help keep subsequent changes smaller.

Steps to test

@shakyShane
Copy link
Collaborator Author

shakyShane commented Sep 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane changed the base branch from main to shane/ntp-debug-bar September 27, 2024 09:18
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch 3 times, most recently from 26ccf9b to 0275f6d Compare September 27, 2024 10:01
@shakyShane shakyShane changed the base branch from shane/ntp-debug-bar to shane/ntp-icons September 27, 2024 10:01
@shakyShane shakyShane mentioned this pull request Sep 27, 2024
Base automatically changed from shane/ntp-icons to main September 27, 2024 10:44
Copy link

github-actions bot commented Oct 4, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch 3 times, most recently from b74bedd to e451a21 Compare October 4, 2024 14:45
@shakyShane shakyShane changed the base branch from main to 10-01-move_tests_to_playwright October 4, 2024 14:45
@shakyShane shakyShane force-pushed the 10-01-move_tests_to_playwright branch from 2d3b811 to 799e2ff Compare October 4, 2024 14:50
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from e451a21 to 5061faa Compare October 4, 2024 14:50
@shakyShane shakyShane mentioned this pull request Oct 4, 2024
@shakyShane shakyShane force-pushed the 10-01-move_tests_to_playwright branch from 799e2ff to 17612a2 Compare October 4, 2024 15:00
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from 3a72975 to e39295a Compare October 4, 2024 15:00
@shakyShane shakyShane force-pushed the 10-01-move_tests_to_playwright branch from 17612a2 to cb9eeab Compare October 4, 2024 19:20
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch 2 times, most recently from 1611975 to 89c35ed Compare October 4, 2024 19:22
@shakyShane shakyShane marked this pull request as ready for review October 7, 2024 12:10
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from 331d9c5 to 8dbf1e3 Compare October 10, 2024 06:55
@shakyShane shakyShane force-pushed the 10-01-move_tests_to_playwright branch from 2f73d83 to a917295 Compare October 10, 2024 10:16
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from 8dbf1e3 to 57755d8 Compare October 10, 2024 10:16
@shakyShane shakyShane force-pushed the 10-01-move_tests_to_playwright branch from a917295 to 27a1689 Compare October 10, 2024 11:59
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch 2 times, most recently from 04d475e to 5adcb29 Compare October 10, 2024 13:26
Base automatically changed from 10-01-move_tests_to_playwright to main October 10, 2024 13:51
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from 5adcb29 to 01108d2 Compare October 10, 2024 13:54
mgurgel
mgurgel previously approved these changes Oct 10, 2024
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from 41a640b to d2dd18e Compare October 10, 2024 16:27
@shakyShane shakyShane merged commit 06e6214 into main Oct 10, 2024
6 checks passed
@shakyShane shakyShane deleted the 09-25-ntp_privacy_stats_widget branch October 10, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants