Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set screenY and screenTop to 0 when equal to screen height #889

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ladamski
Copy link
Contributor

@ladamski ladamski commented Jan 5, 2024

Background: https://app.asana.com/0/276630244458377/1206165160907347/f
See also https://developer.mozilla.org/en-US/docs/Web/API/Window/screenY

For Mac where we are incorrectly providing the screen height instead of A number equal to the number of CSS pixels from the top edge of the browser viewport to the top edge of the screen., which should be the actual value or 0.

@ladamski ladamski marked this pull request as draft January 5, 2024 03:11
@ladamski ladamski marked this pull request as ready for review January 9, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants