Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

big performance difference #42

Open
wants to merge 12 commits into
base: daffy
Choose a base branch
from
Open

big performance difference #42

wants to merge 12 commits into from

Conversation

AndreaCensi
Copy link
Member

No description provided.

@AndreaCensi
Copy link
Member Author

There is a lot of performance loss in importing certain packages at each iteration.

@CourchesneA
Copy link
Contributor

Can we move all of the QuickApp, zuper-* etc to the base image https://github.com/duckietown/dt-base-environment ?

@AndreaCensi
Copy link
Member Author

Good for me -- I didn't choose where the deps go.

@AndreaCensi
Copy link
Member Author

@afdaniele please merge - contains python 2/3 fixes that are inhibiting dt-core unittests

@AndreaCensi
Copy link
Member Author

@afdaniele ping

dt-core unit tests are failing because of this: https://app.circleci.com/pipelines/github/duckietown/dt-core/75/workflows/17e93eff-813d-4137-8bf3-bea730a742ed/jobs/84

@afdaniele
Copy link
Member

@CourchesneA these are leftovers from the Python2 -> 3 migration, can you please fix? Thanks

@CourchesneA
Copy link
Contributor

done. I would need more info on how to run the other tests to prevent more errors from encoding

@AndreaCensi
Copy link
Member Author

actually hold on on this

I'm finding more and more 2→3 problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@afdaniele afdaniele

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreaCensi @CourchesneA @afdaniele