Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only signal done when close is actually finished #105

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

marknelissen
Copy link
Contributor

In this PR:

  • Bug fix (non-breaking change which fixes an issue)

Make the plugin only signal done when socket.io is actually closed. Otherwise one might end up closing e.g. the Mongo connection the adapters are depending on. Will be even more relevant after socketio/socket.io#4971 has been merged.

Issues reference:

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code with pnpm lint locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran build with pnpm build of your changes locally?
  • Have you successfully ran tests with pnpm test of your changes locally?
  • Have you commit using Conventional Commits?

@alemagio alemagio merged commit b03dc28 into ducktors:master Aug 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants