-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove recursive scanning of backup file #2
Comments
I don't really get what you mean by "recursive scanning of backup file". Also, If we set |
A very poor implementation would require you to scan the backup folder after backing up the entire drive, and removing offending folders. |
We're just trying to fix the bug that destination can't be a child of the source directory (while keeping the rest of the functionality of the script as is) right? because if that's the case I've thought of something. Too lazy to implement it though. |
Huh. What is it? |
We just store all the directories in source and then walk over every one of them? children = os.listdir(src_root)
for child in children:
for cur_dir, dirs, files in os.walk(os.path.join(src_root, child)):
... rest of the code same ... |
Now that I've written it, I can see that this is only a partial solution and won't work in all cases. |
set topdown=False inside os.walk., at least till you replace it with scandir (which looks pretty neat, might steal that idea)
The text was updated successfully, but these errors were encountered: