Skip to content

Comments

Update to v5#9

Open
OmgRod wants to merge 1 commit intodulakgg:mainfrom
OmgRod:main
Open

Update to v5#9
OmgRod wants to merge 1 commit intodulakgg:mainfrom
OmgRod:main

Conversation

@OmgRod
Copy link

@OmgRod OmgRod commented Feb 19, 2026

Mod works (however the popup looks a bit off because of the new popup code)
image

Copilot AI review requested due to automatic review settings February 19, 2026 11:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the mod to target Geode v5 / GD 2.2081, including migrating the popup implementation and updating the web request handling to the newer async APIs.

Changes:

  • Migrated MyPopup from geode::Popup<>/setup() to geode::Popup/init().
  • Replaced EventListener<web::WebTask>-based downloading with async::TaskHolder<web::WebResponse> and WebRequest::get.
  • Bumped mod.json to geode: 5.0.0-beta.3 and GD 2.2081 targets.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/main.cpp Updates popup init flow and replaces web download logic with v5 async task holder pattern.
mod.json Updates Geode and GD version constraints for v5/2.2081 compatibility.
Comments suppressed due to low confidence (1)

src/main.cpp:175

  • The error log message here is unprofessional/unclear ("interesting reset your dns pls))"). Please replace it with a concise, actionable message (e.g., include the URL and the parse error) so logs are useful for debugging and appropriate for release builds.
                if (!parsed) {
                    log::error("JSON failed (interesting reset your dns pls)): {}", parsed.unwrapErr());
                    return;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 2 to 4
#include <Geode/utils/web.hpp>
#include <Geode/loader/Event.hpp>
#include <Geode/modify/SecretLayer5.hpp>
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include <Geode/loader/Event.hpp> is now unused after replacing EventListener<web::WebTask> with async::TaskHolder<...>. Please remove the unused include to avoid compiler warnings and keep the includes minimal.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant