Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the mod to target Geode v5 / GD 2.2081, including migrating the popup implementation and updating the web request handling to the newer async APIs.
Changes:
- Migrated
MyPopupfromgeode::Popup<>/setup()togeode::Popup/init(). - Replaced
EventListener<web::WebTask>-based downloading withasync::TaskHolder<web::WebResponse>andWebRequest::get. - Bumped
mod.jsontogeode: 5.0.0-beta.3and GD2.2081targets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main.cpp | Updates popup init flow and replaces web download logic with v5 async task holder pattern. |
| mod.json | Updates Geode and GD version constraints for v5/2.2081 compatibility. |
Comments suppressed due to low confidence (1)
src/main.cpp:175
- The error log message here is unprofessional/unclear ("interesting reset your dns pls))"). Please replace it with a concise, actionable message (e.g., include the URL and the parse error) so logs are useful for debugging and appropriate for release builds.
if (!parsed) {
log::error("JSON failed (interesting reset your dns pls)): {}", parsed.unwrapErr());
return;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2
to
4
| #include <Geode/utils/web.hpp> | ||
| #include <Geode/loader/Event.hpp> | ||
| #include <Geode/modify/SecretLayer5.hpp> |
There was a problem hiding this comment.
#include <Geode/loader/Event.hpp> is now unused after replacing EventListener<web::WebTask> with async::TaskHolder<...>. Please remove the unused include to avoid compiler warnings and keep the includes minimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mod works (however the popup looks a bit off because of the new popup code)
